Copilot commented on code in PR #61190: URL: https://github.com/apache/doris/pull/61190#discussion_r2911712120
########## regression-test/suites/search/test_disable_root_variant_match.groovy: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_disable_root_variant_match", "p0") { + sql """ set enable_match_without_inverted_index = false """ + sql """ set enable_common_expr_pushdown = true """ + sql """ set default_variant_enable_typed_paths_to_sparse = false """ + sql """ set default_variant_enable_doc_mode = false """ + + sql "DROP TABLE IF EXISTS test_disable_root_variant_match_tbl" + + sql """ + CREATE TABLE test_disable_root_variant_match_tbl ( Review Comment: The table name is hard-coded and repeated across the test; in this suite most tests define a `def tableName` and use `${tableName}` to avoid accidental collisions and make renaming/extension easier. Consider introducing a `tableName` variable and interpolating it throughout the SQL strings (DROP/CREATE/INSERT/SELECT). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
