github-actions[bot] commented on code in PR #3439:
URL: https://github.com/apache/doris-website/pull/3439#discussion_r2912908046


##########
docs/query-acceleration/query-cache.md:
##########
@@ -0,0 +1,231 @@
+# Query Cache
+

Review Comment:
   **Missing front matter.** Every sibling file in this directory 
(`sql-cache-manual.md`, `condition-cache.md`, `colocation-join.md`, etc.) has a 
JSON front matter block with `title`, `language`, and `description` fields. 
This file should have one too, for example:
   
   ```md
   ---
   {
       "title": "Query Cache",
       "language": "en",
       "description": "Query Cache caches intermediate aggregation results in 
the pipeline execution engine to accelerate repeated analytical queries on 
internal OLAP tables."
   }
   ---
   ```
   
   Without front matter, Docusaurus may not set the correct page title and meta 
description for SEO.



##########
versioned_docs/version-4.x/query-acceleration/query-cache.md:
##########
@@ -0,0 +1,231 @@
+# Query Cache
+

Review Comment:
   **Missing front matter** — same issue as the `docs/` copy. This file should 
include JSON front matter with `title`, `language`, and `description` to match 
every other file in this directory.



##########
versioned_sidebars/version-4.x-sidebars.json:
##########
@@ -632,6 +632,7 @@
                             "label": "Caching",
                             "items": [
                                 "query-acceleration/sql-cache-manual",
+                                "query-acceleration/query-cache",
                                 "query-acceleration/condition-cache",

Review Comment:
   The `version-4.x-sidebars.json` is correctly updated, but **`sidebars.ts` 
(the `current`/dev version sidebar) was not updated**. The file 
`docs/query-acceleration/query-cache.md` exists on disk but is orphaned from 
navigation — users browsing the dev docs cannot reach it via the sidebar.
   
   Please add `'query-acceleration/query-cache'` to the Caching category in 
`sidebars.ts` (around line 630), matching the placement here:
   
   ```ts
   {
       type: 'category',
       label: 'Caching',
       items: [
           'query-acceleration/sql-cache-manual',
           'query-acceleration/query-cache',  // <-- add this
           'query-acceleration/condition-cache',
           
'query-acceleration/tuning/tuning-plan/accelerating-queries-with-sql-cache',
       ],
   },
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to