github-actions[bot] commented on code in PR #61234:
URL: https://github.com/apache/doris/pull/61234#discussion_r2918753136
##########
env.sh:
##########
@@ -17,9 +17,13 @@
# specific language governing permissions and limitations
# under the License.
-# check DORIS_HOME
-export LC_ALL=C
+# Explicitly set to prevent ccache misses caused by terminal differences
+export LANG=C.UTF-8
+export LC_ALL=C.UTF-8
+export LC_CTYPE=C.UTF-8
+export LC_MESSAGES=C.UTF-8
Review Comment:
Minor concern: `C.UTF-8` is widely available on modern Linux but is not
guaranteed by POSIX and may be absent on some minimal Docker images or older
systems. If unavailable, behavior varies — some systems silently fall back,
others may print warnings to stderr on every script invocation.
Consider adding a guard, e.g.:
```bash
if locale -a 2>/dev/null | grep -qiF 'c.utf'; then
export LANG=C.UTF-8
export LC_ALL=C.UTF-8
...
else
export LC_ALL=C
fi
```
Or at minimum, document that `C.UTF-8` is assumed available in the build
environment.
##########
env.sh:
##########
@@ -353,10 +357,23 @@ if NINJA_VERSION="$(ninja --version 2>/dev/null)"; then
BUILD_SYSTEM="ninja"
fi
+# for worktree build, use ubsan_ignorelist.txt from main branch to avoid
ccache miss.
+if [[ -z "${UBSAN_IGNORELIST}" ]]; then
+ export UBSAN_IGNORELIST="${DORIS_HOME}/conf/ubsan_ignorelist.txt"
+fi
+
if CCACHE_VERSION="$(ccache --version 2>/dev/null)"; then
echo "${CCACHE_VERSION}" | head -n 1
# shellcheck disable=2034
- CMAKE_USE_CCACHE="-DCMAKE_CXX_COMPILER_LAUNCHER=ccache"
+ CMAKE_USE_CCACHE="-DCMAKE_CXX_COMPILER_LAUNCHER=ccache
-DCMAKE_C_COMPILER_LAUNCHER=ccache"
+
+ export CCACHE_BASEDIR=${DORIS_HOME}
+ export CCACHE_NOHASHDIR=1
+ export CCACHE_COMPRESS=1
+ export CCACHE_IGNOREOPTIONS='-ffile-prefix-map=*' # we remap path in
different repo to one. the item itself could be ignore.
+ # for debug. when debug enabled, will generate text fingerprint file
*.ccache-input-text
Review Comment:
Nit: Missing quotes around `${DORIS_HOME}`. If the path ever contains spaces
(unlikely but possible), this would break.
```suggestion
export CCACHE_BASEDIR="${DORIS_HOME}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
