jacktengg commented on code in PR #61173:
URL: https://github.com/apache/doris/pull/61173#discussion_r2921858554
##########
be/src/vec/common/pod_array_fwd.h:
##########
@@ -32,17 +32,15 @@ inline constexpr size_t integerRoundUp(size_t value, size_t
dividend) {
return ((value + dividend - 1) / dividend) * dividend;
}
-template <typename T, size_t initial_bytes = 4096,
- typename TAllocator = Allocator<false, false, false,
DefaultMemoryAllocator, false>,
+template <typename T, size_t initial_bytes = 4096, typename TAllocator =
Allocator<false>,
size_t pad_right_ = 0, size_t pad_left_ = 0>
class PODArray;
/** For columns. Padding is enough to read and write xmm-register at the
address of the last element.
* TODO, Adapt internal data structures to 512-bit era
https://github.com/ClickHouse/ClickHouse/pull/42564
* Padding in internal data structures increased to 64 bytes., support
AVX-512 simd.
*/
-template <typename T, size_t initial_bytes = 4096,
- typename TAllocator = Allocator<false, false, false,
DefaultMemoryAllocator, false>>
+template <typename T, size_t initial_bytes = 4096, typename TAllocator =
Allocator<false>>
Review Comment:
现在的写法，就是123c649328cb84f6394db29a149b11fdc5809c9b， pr #50737的写法，也就是
"[opt](memtracker) Optimize `PODArray` memory tracking accuracy
(#50549)"前面那个pr的写法。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
