CalvinKirs commented on code in PR #61031:
URL: https://github.com/apache/doris/pull/61031#discussion_r2922769966
##########
be/src/format/table/paimon_doris_file_system.cpp:
##########
@@ -86,7 +86,7 @@ bool is_s3_scheme(const std::string& scheme) {
}
bool is_hdfs_scheme(const std::string& scheme) {
- return scheme == "hdfs" || scheme == "viewfs" || scheme == "local";
+ return scheme == "hdfs" || scheme == "viewfs" || scheme == "local" ||
scheme == "jfs";
Review Comment:
Using a configuration file might work here. In the future, we may have
additional schemas such as OSS, S3A, GS, and others. If we hard-code them,
every new schema would require a code change, which could become cumbersome.
This probably deserves a broader discussion, so there's no urgency to modify
it right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
