github-actions[bot] commented on code in PR #61256:
URL: https://github.com/apache/doris/pull/61256#discussion_r2923320055
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java:
##########
@@ -697,7 +696,7 @@ public ExternalDatabase<? extends ExternalTable>
getDbNullable(String dbName) {
LOG.warn("failed to get db {} in catalog {}", dbName, name, e);
return null;
}
- String realDbName = ClusterNamespace.getNameFromFullName(dbName);
+ String realDbName = dbName;
Review Comment:
Nit: `String realDbName = dbName;` is now a trivially redundant alias.
Consider just using `dbName` directly throughout the rest of this method, or
renaming the parameter. Same pattern appears in several other files
(MetaInfoAction, MetaInfoActionV2, ShowDatabasesCommand, LdapAuthenticator,
LdapManager, ShowCreateDatabaseCommand, FrontendServiceImpl).
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java:
##########
@@ -194,7 +192,7 @@ public void writeFileResponse(HttpServletRequest request,
}
public String getFullDbName(String dbName) {
- return ClusterNamespace.getNameFromFullName(dbName);
+ return dbName;
}
Review Comment:
Nit: `getFullDbName(String dbName)` is now a pure identity function (`return
dbName;`). It has **22 call sites** across 14 files. Consider removing this
method and inlining the argument at all call sites — either in this PR or as a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
