englefly commented on code in PR #14526:
URL: https://github.com/apache/doris/pull/14526#discussion_r1033588030
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Table.java:
##########
@@ -511,4 +511,22 @@ public Set<String> getPartitionNames() {
public AnalysisJob createAnalysisJob(AnalysisJobScheduler scheduler,
AnalysisJobInfo info) {
throw new NotImplementedException();
}
+
+ /**
+ * for NOT-ANALYZED Olap table, return estimated row count,
+ * for other table, return 1
Review Comment:
"1" is better. Because we do not tell if this value is negative or not.
if it returns '-1', after it joins with other table, the result negative
row count, and all row count comparison should be re-implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
