morrySnow opened a new pull request, #61304:
URL: https://github.com/apache/doris/pull/61304
Move getStringValueForQuery, getStringValueInComplexTypeForQuery, and
getStringValueForStreamLoad logic from 17 Expr subclasses into a centralized
ExprToStringValueVisitor, following the same visitor pattern as
ExprToSqlVisitor and ExprToThriftVisitor.
New classes:
- ExprToStringValueVisitor: visitor with visit methods for DateLiteral,
FloatLiteral, BoolLiteral, NullLiteral, DecimalLiteral, ArrayLiteral,
MapLiteral, StructLiteral, CastExpr, StringLiteral, IPv4Literal, IPv6Literal,
VarBinaryLiteral, PlaceHolderExpr, JsonLiteral, MaxLiteral
- StringValueContext: carries FormatOptions and mode flags (forStreamLoad,
inComplexType)
Expr base class methods now delegate to the visitor. Subclass overrides are
removed. Also fixes pre-existing local variable naming in DateLiteral static
block (DATE_KEY_FORMATTER -> dateKeyFmt) and makes convertToString private (no
external callers).
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
