BiteTheDDDDt commented on code in PR #14641:
URL: https://github.com/apache/doris/pull/14641#discussion_r1034242668
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -311,6 +311,15 @@ class ColumnNullable final : public COWHelper<IColumn,
ColumnNullable> {
void sort_column(const ColumnSorter* sorter, EqualFlags& flags,
IColumn::Permutation& perms,
EqualRange& range, bool last_column) const override;
+ void set_rowset_segment_id(std::pair<RowsetId, uint32_t>
rowset_segment_id) override {
+ Base::set_rowset_segment_id(rowset_segment_id);
Review Comment:
`Base::set_rowset_segment_id(rowset_segment_id);`
Maybe we can remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
