englefly opened a new pull request, #61342:
URL: https://github.com/apache/doris/pull/61342
### What problem does this PR solve?
When FE starts with -r (metadata_failure_recovery) or without a checkpoint
image, it replays all journal logs from the beginning. Old journal entries may
contain PrimaryKeyConstraint objects that were serialized before the fields
foreignTables, foreignTableNameStrs, or foreignTableInfos were added to the
class.
Gson uses Unsafe to instantiate objects during deserialization, bypassing
the constructor and its field initializers. If a field is absent from the JSON,
Gson leaves it as null rather than using the declared initializer (e.g. `= new
HashSet<>()`). Calling .isEmpty() or any method on a null collection then
throws a NullPointerException.
Fix: remove `final` from the three collection fields (so they can be
reassigned in gsonPostProcess) and add null-guards at the top of
gsonPostProcess() to initialize them to empty collections when absent.
Impact on -r mode: when FE is started with --metadata_failure_recovery it
replays every journal from journal #1, encountering the oldest serialized
PrimaryKeyConstraint objects. Without this fix, FE always crashes during -r
recovery if any PrimaryKeyConstraint was persisted before these fields existed.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
