foxtail463 opened a new pull request, #61345:
URL: https://github.com/apache/doris/pull/61345
compensation with DNF implication
The old residual compensation simply checks whether the query residual set
contains all view residual predicates. This breaks on real-world MV rewrites
where query and view residuals are structurally different but logically
implicative -- e.g. query residual
A OR (B AND C)
vs view residual
A OR B
The old code sees two different expression trees and bails out, even though
the query side is strictly stronger.
This patch introduces DNF-based implication checking (impliesByDnf) to
replace the set-containment approach, so compensation succeeds whenever the
query candidates logically imply the view residual regardless of structural
differences. A hard cap (MAX_DNF_BRANCHES=1024) guards against exponential
expansion; when the proof is too expensive the compensation fails
conservatively rather than hanging the optimizer.
The three separate compensate calls in AbstractMaterializedViewRule are
collapsed into a single Predicates.compensatePredicates entry point that
encapsulates candidate collection and residual finalization.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
