jacktengg commented on code in PR #61212:
URL: https://github.com/apache/doris/pull/61212#discussion_r2937841890
##########
be/src/exec/operator/partitioned_aggregation_source_operator.h:
##########
@@ -41,30 +59,68 @@ class PartitionedAggLocalState MOCK_REMOVE(final)
Status open(RuntimeState* state) override;
Status close(RuntimeState* state) override;
- Status recover_blocks_from_disk(RuntimeState* state, bool& has_data);
- Status setup_in_memory_agg_op(RuntimeState* state);
+ bool is_blockable() const override;
- template <bool spilled>
- void update_profile(RuntimeProfile* child_profile);
+ /// Flush the current in-memory hash table by draining it as blocks and
routing
+ /// each block through the repartitioner into the output sub-spill-files.
+ Status flush_hash_table_to_sub_spill_files(RuntimeState* state);
- bool is_blockable() const override;
+ /// Flush the in-memory hash table into FANOUT sub-spill-files,
repartition remaining
+ /// unread spill files from `remaining_spill_files`, and push resulting
sub-partitions into
+ /// `_partition_queue`. After this call the hash table is reset and
+ /// `remaining_spill_files` is cleared.
+ Status flush_and_repartition(RuntimeState* state);
Review Comment:
Declared but no definition, delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
