yiguolei commented on code in PR #61130:
URL: https://github.com/apache/doris/pull/61130#discussion_r2938381013
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -176,13 +191,7 @@ void PipelineFragmentContext::cancel(const Status reason) {
.tag("query_id", print_id(_query_id))
.tag("fragment_id", _fragment_id)
.tag("reason", reason.to_string());
- {
- std::lock_guard<std::mutex> l(_task_mutex);
- if (_closed_tasks >= _total_tasks) {
- // All tasks in this PipelineXFragmentContext already closed.
- return;
- }
- }
+ notify_close();
Review Comment:
这个从语义上跟之前不等价
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]