Copilot commented on code in PR #61373:
URL: https://github.com/apache/doris/pull/61373#discussion_r2938569892
##########
sdk/go-doris-sdk/pkg/load/config/load_config.go:
##########
@@ -141,6 +142,12 @@ func (c *Config) ValidateInternal() error {
return fmt.Errorf("format cannot be nil")
}
+ if c.EnableGzip {
+ if _, ok := c.Format.(*CSVFormat); !ok {
Review Comment:
Config.ValidateInternal currently enforces gzip support by type-asserting
c.Format to *CSVFormat. Since Format is an interface, this rejects any custom
Format implementation that still returns CSV options. Consider validating via
c.Format.GetFormatType() == "csv" (or another interface-level signal) instead
of a concrete type check.
##########
sdk/go-doris-sdk/cmd/examples/main.go:
##########
@@ -75,6 +75,9 @@ func runExample(name string) {
case "basic":
fmt.Println("Running Basic Concurrent Example...")
examples.RunBasicConcurrentExample()
+ case "gzip":
+ fmt.Println("Running Gzip Compression Example...")
+ examples.GzipExample()
Review Comment:
The new "gzip" example can be selected via the switch, but the usage/help
text at the top of this file (Available Examples list and examples) is not
updated to mention it. This makes the CLI help inconsistent with the supported
options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
