Gabriel39 commented on code in PR #14674:
URL: https://github.com/apache/doris/pull/14674#discussion_r1034697074
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -295,12 +295,15 @@ struct DecimalBinaryOperation {
for (size_t i = 0; i < size; ++i) {
c[i] = apply_scaled_div(a, b[i]);
}
- return;
- }
-
- /// default: use it if no return before
- for (size_t i = 0; i < size; ++i) {
- c[i] = apply(a, b[i]);
+ } else if constexpr (IsDecimalNumber<A> || IsDecimalNumber<B>) {
Review Comment:
```suggestion
} else if constexpr (IsDecimalV2<A> || IsDecimalV2<B>) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
