This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 76511c1126b [fix](decimalv2) fix wrong result of abs(decimalv2)
(#61397)
76511c1126b is described below
commit 76511c1126b31afc812642dc4eb2bd331dfbabc1
Author: TengJianPing <[email protected]>
AuthorDate: Tue Mar 17 11:08:43 2026 +0800
[fix](decimalv2) fix wrong result of abs(decimalv2) (#61397)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Function `abs(decimalv2)` is executed by passing `DecimalV2Value` type
value, should specialize template `ResultOfAbs<DecimalV2Value>` to get
correct result type.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/core/data_type/number_traits.h | 4 +++
.../datatype_p0/decimalv2/test_decimalv2_rqg.out | 14 ++++++++
.../decimalv2/test_decimalv2_rqg.groovy | 41 ++++++++++++++++++++++
3 files changed, 59 insertions(+)
diff --git a/be/src/core/data_type/number_traits.h
b/be/src/core/data_type/number_traits.h
index 3b8c742470d..0039bb92076 100644
--- a/be/src/core/data_type/number_traits.h
+++ b/be/src/core/data_type/number_traits.h
@@ -229,6 +229,10 @@ struct ResultOfAbs<Decimal128V2> {
static constexpr PrimitiveType Type = TYPE_DECIMALV2;
};
template <>
+struct ResultOfAbs<DecimalV2Value> {
+ static constexpr PrimitiveType Type = TYPE_DECIMALV2;
+};
+template <>
struct ResultOfAbs<Decimal128V3> {
static constexpr PrimitiveType Type = TYPE_DECIMAL128I;
};
diff --git a/regression-test/data/datatype_p0/decimalv2/test_decimalv2_rqg.out
b/regression-test/data/datatype_p0/decimalv2/test_decimalv2_rqg.out
new file mode 100644
index 00000000000..ab867af517b
--- /dev/null
+++ b/regression-test/data/datatype_p0/decimalv2/test_decimalv2_rqg.out
@@ -0,0 +1,14 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !rqg_decimalv2_abs --
+0E-9
+1.000000000
+1.000000000
+1000000000.000000000
+1000000000.000000000
+1111111111.000000000
+1111111111.000000000
+1234567890.000000000
+1234567890.000000000
+9999999999.000000000
+9999999999.000000000
+
diff --git
a/regression-test/suites/datatype_p0/decimalv2/test_decimalv2_rqg.groovy
b/regression-test/suites/datatype_p0/decimalv2/test_decimalv2_rqg.groovy
index f5c9615740a..503bbdac5d1 100644
--- a/regression-test/suites/datatype_p0/decimalv2/test_decimalv2_rqg.groovy
+++ b/regression-test/suites/datatype_p0/decimalv2/test_decimalv2_rqg.groovy
@@ -56,4 +56,45 @@ suite("test_decimalv2_rqg") {
sql """
SELECT CEIL(ARG0,CAST(-1 AS INT)) FROM (SELECT TEMPDATA . data,
TABLE0.ARG0 FROM TEMPDATA CROSS JOIN (SELECT data AS ARG0 FROM
DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE ) AS TABLE0) t ;
"""
+
+ multi_sql """
+ DROP TABLE IF EXISTS TEMPDATA;
+ CREATE TABLE TEMPDATA(id INT, data INT) DISTRIBUTED BY HASH(id)
BUCKETS 1 PROPERTIES ('replication_num' = '1');
+ INSERT INTO TEMPDATA values(1, 1);
+ """
+ multi_sql """
+ DROP TABLE IF EXISTS DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE;
+ CREATE TABLE IF NOT EXISTS
DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE(id INT, data DECIMALV2(10,0) NOT
NULL) DISTRIBUTED BY HASH(id) BUCKETS 1 PROPERTIES ('replication_num' = '1');
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (0,
1234567890);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (1,
9999999999);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (2,
1000000000);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (3,
1111111111);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (4,
-1234567890);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (5,
-9999999999);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (6,
-1000000000);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (7,
-1111111111);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (8, 1);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (9, 0);
+ INSERT INTO DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE values (10, -1);
+ """
+ qt_rqg_decimalv2_abs """
+ SELECT
+ ABS(NULLABLE(ARG0)) col0
+ FROM
+ (
+ SELECT
+ TEMPDATA.data,
+ TABLE0.ARG0
+ FROM
+ TEMPDATA
+ CROSS JOIN (
+ SELECT
+ data AS ARG0
+ FROM
+ DECIMALV2_10_0_DATA_NOT_EMPTY_NOT_NULLABLE
+ ) AS TABLE0
+ ) t
+ ORDER BY
+ col0;
+ """
}
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
