xuchenhao commented on PR #59065: URL: https://github.com/apache/doris/pull/59065#issuecomment-4072074416
Update for yesterday's 3 review comments (no CI trigger in this message): 1) https://github.com/apache/doris/pull/59065#discussion_r2942716467 - Accepted and addressed: `file_cache_admission_control_json_dir` is now `mutable = false` to match startup-only watcher behavior. 2) https://github.com/apache/doris/pull/59065#discussion_r2942716463 - Accepted and addressed: removed `"hudi"` from `CACHEABLE_CATALOGS`, kept `"hms"` and clarified comment as `Hudi(via HMS)`. 3) https://github.com/apache/doris/pull/59065#discussion_r2942716455 - Accepted and addressed: moved database extraction into `ExternalTable` branch; non-external debug log now uses null-safe catalog/database/table output to avoid NPE. If reviewers prefer different log wording, I can adjust accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
