Copilot commented on code in PR #61649:
URL: https://github.com/apache/doris/pull/61649#discussion_r2978827893
##########
docker/thirdparties/docker-compose/iceberg/entrypoint.sh.tpl:
##########
@@ -55,16 +55,6 @@ EXECUTION_TIME2=$((END_TIME2 - START_TIME2))
echo "Script paimon total: {} executed in $EXECUTION_TIME2 seconds"
-
-ls /mnt/scripts/create_preinstalled_scripts/iceberg_scala/*.scala | xargs -n 1
-I {} bash -c '
- START_TIME=$(date +%s)
- spark-shell --conf
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions
-I {}
- END_TIME=$(date +%s)
- EXECUTION_TIME=$((END_TIME - START_TIME))
- echo "Script: {} executed in $EXECUTION_TIME seconds"
-'
-
-
START_TIME3=$(date +%s)
find /mnt/scripts/create_preinstalled_scripts/iceberg_load -name '*.sql' | sed
's|^|source |' | sed 's|$|;|'> iceberg_load_total.sql
spark-sql --master spark://doris--spark-iceberg:7077 --conf
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions
-f iceberg_load_total.sql
Review Comment:
`find ... -name '*.sql'` does not guarantee a stable ordering. Several
existing `runXX.sql` scripts appear to rely on earlier scripts having already
run (e.g. `run27.sql` only does `use demo.test_db;` and doesn’t create the DB),
so a non-deterministic execution order can cause intermittent bootstrap
failures or objects being created in the wrong database. Please sort the file
list before generating the aggregated `*_total.sql` (and apply the same fix to
the other `find ... > *_total.sql` pipelines in this script).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
