seawinde commented on code in PR #61290:
URL: https://github.com/apache/doris/pull/61290#discussion_r2979933285
##########
regression-test/suites/nereids_rules_p0/mv/agg_with_roll_up/aggregate_with_roll_up.groovy:
##########
@@ -1602,12 +1647,6 @@ suite("aggregate_with_roll_up") {
l_suppkey
order by o_orderstatus;
"""
- order_qt_query36_0_before "${query36_0}"
- async_mv_rewrite_fail(db, mv36_0, query36_0, "mv36_0")
- order_qt_query36_0_after "${query36_0}"
- sql """ DROP MATERIALIZED VIEW IF EXISTS mv36_0"""
-
-
// mv is merge, query is union
def mv37_0 = """
Review Comment:
In aggregate_with_roll_up.groovy, several MV merges changed the test
semantics: query13_1 is now validated against mv13_0 instead of its original
mv13_1, and query37_0 against mv36_0 instead of mv37_0. Since these MVs have
different definitions, the "rewrite fail" assertions may pass trivially against
the wrong MV. Have these merged cases been verified to still cover the
originally intended rewrite scenarios?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
