Gabriel39 commented on code in PR #61300:
URL: https://github.com/apache/doris/pull/61300#discussion_r2980114875
##########
be/src/core/field.cpp:
##########
@@ -822,6 +844,64 @@ std::string_view Field::as_string_view() const {
#undef MATCH_PRIMITIVE_TYPE
+// Important!!! This method is not accurate, for example, decimal to string,
it uses scale == 0, because
+// it do not know the actual scale of the decimal value. It is only used for
debug printing, so it is fine.
+std::string Field::to_debug_string(int scale) const {
+ if (is_null()) {
+ return "NULL";
+ }
+ switch (type) {
+ case PrimitiveType::TYPE_BOOLEAN:
+ return get<TYPE_BOOLEAN>() ? "true" : "false";
+ case PrimitiveType::TYPE_TINYINT:
+ return CastToString::from_number(get<TYPE_TINYINT>());
+ case PrimitiveType::TYPE_SMALLINT:
+ return CastToString::from_number(get<TYPE_SMALLINT>());
+ case PrimitiveType::TYPE_INT:
+ return CastToString::from_number(get<TYPE_INT>());
+ case PrimitiveType::TYPE_BIGINT:
+ return CastToString::from_number(get<TYPE_BIGINT>());
+ case PrimitiveType::TYPE_LARGEINT:
+ return CastToString::from_number(get<TYPE_LARGEINT>());
+ case PrimitiveType::TYPE_FLOAT:
+ return CastToString::from_number(get<TYPE_FLOAT>());
+ case PrimitiveType::TYPE_DOUBLE:
+ return CastToString::from_number(get<TYPE_DOUBLE>());
+ case PrimitiveType::TYPE_STRING:
+ case PrimitiveType::TYPE_CHAR:
+ case PrimitiveType::TYPE_VARCHAR:
+ return get<TYPE_STRING>();
+ case PrimitiveType::TYPE_VARBINARY:
+ return get<TYPE_VARBINARY>();
+ case PrimitiveType::TYPE_DATE:
+ return CastToString::from_date_or_datetime(get<TYPE_DATE>());
+ case PrimitiveType::TYPE_DATETIME:
+ return CastToString::from_date_or_datetime(get<TYPE_DATETIME>());
+ case PrimitiveType::TYPE_DATEV2:
+ return CastToString::from_datev2(get<TYPE_DATEV2>());
+ case PrimitiveType::TYPE_DATETIMEV2:
+ return CastToString::from_datetimev2(get<TYPE_DATETIMEV2>(), scale);
+ case PrimitiveType::TYPE_TIMESTAMPTZ:
+ return CastToString::from_timestamptz(get<TYPE_TIMESTAMPTZ>(), scale);
+ case PrimitiveType::TYPE_DECIMALV2:
+ return get<TYPE_DECIMALV2>().to_string();
+ case PrimitiveType::TYPE_DECIMAL32:
+ return CastToString::from_decimal(get<TYPE_DECIMAL32>(), scale);
+ case PrimitiveType::TYPE_DECIMAL64:
+ return CastToString::from_decimal(get<TYPE_DECIMAL64>(), scale);
+ case PrimitiveType::TYPE_DECIMAL128I:
+ return CastToString::from_decimal(get<TYPE_DECIMAL128I>(), scale);
+ case PrimitiveType::TYPE_DECIMAL256:
+ return CastToString::from_decimal(get<TYPE_DECIMAL256>(), scale);
+ case PrimitiveType::TYPE_IPV4:
+ return CastToString::from_ip(get<TYPE_IPV4>());
+ case PrimitiveType::TYPE_IPV6:
+ return CastToString::from_ip(get<TYPE_IPV6>());
+ default:
+ return get_type_name();
Review Comment:
Why is the type name returned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
