yiguolei commented on code in PR #14746:
URL: https://github.com/apache/doris/pull/14746#discussion_r1037676061
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -519,7 +519,8 @@ Status AggregationNode::get_next(RuntimeState* state,
Block* block, bool* eos) {
RETURN_IF_ERROR(_executor.get_result(state, block, eos));
_make_nullable_output_key(block);
// dispose the having clause, should not be execute in prestreaming agg
- RETURN_IF_ERROR(VExprContext::filter_block(_vconjunct_ctx_ptr, block,
block->columns()));
+ RETURN_IF_CATCH_BAD_ALLOC_OR_ERROR(
+ VExprContext::filter_block(_vconjunct_ctx_ptr, block,
block->columns()));
Review Comment:
Maybe should make sure that filter block is exception safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
