morningman commented on code in PR #61553:
URL: https://github.com/apache/doris/pull/61553#discussion_r2991622066
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/ThriftHMSCachedClient.java:
##########
@@ -636,53 +639,144 @@ private static LockComponent
createLockComponentForRead(TableNameInfo tblName, O
return builder.build();
}
+ /**
+ * The Doris HMS pool only manages client object lifecycle in FE:
+ * 1. Create clients.
+ * 2. Borrow and return clients.
+ * 3. Invalidate borrowers that have already failed.
+ * 4. Destroy clients when the pool is closed.
+ *
+ * The pool does not manage Hive-side socket lifetime or reconnect:
+ * 1. RetryingMetaStoreClient handles
hive.metastore.client.socket.lifetime itself.
+ * 2. The pool does not interpret that config.
+ * 3. The pool does not probe remote socket health.
+ */
+ private GenericObjectPoolConfig createPoolConfig(int poolSize) {
+ GenericObjectPoolConfig config = new GenericObjectPoolConfig();
+ config.setMaxTotal(poolSize);
Review Comment:
Have you tested with poolSize == 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
