morrySnow opened a new pull request, #61738:
URL: https://github.com/apache/doris/pull/61738
## Proposed changes
Remove dead code across five FE packages: `analysis`, `common`, `nereids`,
`planner`, `qe`.
### What problem does this PR solve?
Problem Summary: Accumulated dead code in FE modules increases maintenance
burden and cognitive load. This PR removes:
- **13 unused classes** — never imported/referenced outside their own file
- `NotLiteralExprPredicate`, `BaseProcNode`, `MysqlUtil`, `CommandResult`,
`ExprCostModel`, `FileDumpConsumer`, `ParentTypeIdMapping`,
`DecimalWiderPrecision`, `BucketSpecifyInstances`, `DefaultSpecifyInstances`,
`CustomAssignmentJob`, `ScanRange` (nereids), `ExportSink`
- **21 unused private methods** — declared but never called
- **55 unused public methods** — never called from any other file
- **19 unused fields** — declared but never read (including write-only
fields like `AlterTableOp.needTableStable` and `DistributionDesc.type`)
- Associated orphaned imports cleaned across all modified files
**92 files changed, 1,781 lines deleted.**
### Safety guarantees
All persistence-related code was excluded from removal:
- Classes with `@SerializedName`, `@JsonProperty`, `implements
Writable/GsonPostProcessable`
- Fields/methods involved in `readFields`, `writeObject`, `readObject`,
`Serializable`
- EditLog read/write paths
Known special cases intentionally preserved:
- `PatternDescribableProcessPoint.java` — annotation processor trigger
referenced in pom.xml
- `ParserContext.java` — used by fe_plugins (spark/trino converters)
- `SessionVariable` getters — accessed via reflection through `@VarAttr`
### Review verification
Reviewed by 4 independent AI models (Claude Opus 4.6, GPT-5.4,
GPT-5.3-Codex, Gemini 3 Pro):
- All confirmed no persistence, reflection, or hierarchy issues
- One valid finding (zombie `CommandResult` class after getter removal) was
fixed
### Release note
None
### Check List (For Author)
- Test: No need to test — pure dead code removal, FE clean build verified
- Behavior changed: No
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
