github-actions[bot] commented on code in PR #3495: URL: https://github.com/apache/doris-website/pull/3495#discussion_r2992844128
########## versioned_docs/version-4.x/sql-manual/sql-statements/data-modification/DML/DELETE.md: ########## @@ -46,6 +48,12 @@ DELETE FROM table_name + PARTITION partition_name | PARTITIONS (partition_name [, partition_name]): Specifies the partition or partitions to select rows for removal Review Comment: **Issue: `WHERE condition` contradiction between Syntax and Required Parameters** The syntax block now shows `[WHERE condition]` (optional), but the `#### Required Parameters` section still lists `WHERE condition` as required. Please move it to `#### Optional Parameters`. ########## docs/sql-manual/sql-statements/data-modification/DML/DELETE.md: ########## @@ -46,6 +48,8 @@ DELETE FROM table_name + PARTITION partition_name | PARTITIONS (partition_name [, partition_name]): Specifies the partition or partitions to select rows for removal Review Comment: **Issue: `WHERE condition` contradiction between Syntax and Required Parameters** The syntax block now shows `[WHERE condition]` (optional), but the `#### Required Parameters` section below still lists: ``` + WHERE condition: Specifies a condition to use to select rows for removal ``` This is a direct contradiction. `WHERE condition` should be moved to `#### Optional Parameters` to match the updated syntax. ########## i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-statements/data-modification/DML/DELETE.md: ########## @@ -46,6 +48,8 @@ DELETE FROM table_name [table_alias] + PARTITION partition_name | PARTITIONS (partition_name [, partition_name]): 指定执行删除数据的分区名，如果表不存在此分区，则报错 Review Comment: **问题：`WHERE condition` 在语法块中已标记为可选，但 Required Parameters 节中仍将其列为必填项** 语法块现在显示 `[WHERE condition]`（可选），而下方的 `#### Required Parameters` 节仍列出： ``` + WHERE condition: 指定一个用于选择删除行的条件 ``` 这是直接的矛盾。`WHERE condition` 应移至 `#### Optional Parameters` 节。 ########## docs/sql-manual/sql-statements/data-modification/DML/UPDATE.md: ########## @@ -32,6 +34,8 @@ UPDATE target_table [table_alias] + cte: Common Table Expression, eg 'WITH a AS SELECT * FROM tbl' + table_alias: alias of table + FROM additional_tables: Specifies one or more tables to use for selecting rows to update or for setting new values. Note that if you want use target table here, you should give it a alias explicitly. ++ ORDER BY column: Specifies the order in which rows are updated. Typically used together with LIMIT to control which rows are affected. ++ LIMIT [offset,] count: Limits the number of rows to be updated. When used with ORDER BY, updates the first `count` rows after sorting. If `offset` is specified, skips the first `offset` rows before updating. Review Comment: **Suggestion: Add a safety note about omitting WHERE** Now that `WHERE` is optional, an `UPDATE ... SET col=val` without any `WHERE`, `ORDER BY`, or `LIMIT` would update all rows. Consider adding a note such as: > **Warning**: If neither `WHERE` nor `LIMIT` is specified, all rows in the table will be updated. Always verify the intended scope before omitting the `WHERE` clause. ########## docs/sql-manual/sql-statements/data-modification/DML/DELETE.md: ########## @@ -46,6 +48,8 @@ DELETE FROM table_name + PARTITION partition_name | PARTITIONS (partition_name [, partition_name]): Specifies the partition or partitions to select rows for removal + table_alias: alias of table + USING additional_tables: If you need to refer to additional tables in the WHERE clause to help identify the rows to be removed, then specify those table names in the USING clause. You can also use the USING clause to specify subqueries that identify the rows to be removed. ++ ORDER BY column: Specifies the order in which rows are deleted. Typically used together with LIMIT to control which rows are affected. ++ LIMIT [offset,] count: Limits the number of rows to be deleted. When used with ORDER BY, deletes the first `count` rows after sorting. If `offset` is specified, skips the first `offset` rows before deleting. Review Comment: **Suggestion: Clarify UNIQUE KEY model constraint** The `ORDER BY` and `LIMIT` clauses in Syntax 2 only apply to the UNIQUE KEY model (as stated in the Syntax 2 header). Adding a brief qualifier to the parameter description — e.g., `(Syntax 2 / UNIQUE KEY model only)` — would help users who read Optional Parameters without reading the full syntax preamble. ########## docs/sql-manual/sql-statements/data-modification/DML/DELETE.md: ########## @@ -46,6 +48,8 @@ DELETE FROM table_name + PARTITION partition_name | PARTITIONS (partition_name [, partition_name]): Specifies the partition or partitions to select rows for removal + table_alias: alias of table + USING additional_tables: If you need to refer to additional tables in the WHERE clause to help identify the rows to be removed, then specify those table names in the USING clause. You can also use the USING clause to specify subqueries that identify the rows to be removed. ++ ORDER BY column: Specifies the order in which rows are deleted. Typically used together with LIMIT to control which rows are affected. ++ LIMIT [offset,] count: Limits the number of rows to be deleted. When used with ORDER BY, deletes the first `count` rows after sorting. If `offset` is specified, skips the first `offset` rows before deleting. Review Comment: **Suggestion: Add a safety note about omitting WHERE** Now that `WHERE` is optional, a `DELETE FROM my_table` with no `WHERE`, `ORDER BY`, or `LIMIT` would delete all rows. Consider adding a note such as: > **Warning**: If neither `WHERE` nor `LIMIT` is specified, all rows in the table will be deleted. Always verify the intended scope before omitting the `WHERE` clause. ########## i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/sql-manual/sql-statements/data-modification/DML/DELETE.md: ########## @@ -46,6 +48,12 @@ DELETE FROM table_name [table_alias] + PARTITION partition_name | PARTITIONS (partition_name [, partition_name]): 指定执行删除数据的分区名，如果表不存在此分区，则报错 Review Comment: **问题：`WHERE condition` 在语法块中已标记为可选，但 Required Parameters 节中仍将其列为必填项** 语法块现在显示 `[WHERE condition]`（可选），但 `#### Required Parameters` 节仍将其列为必填项。请将其移至 `#### Optional Parameters` 节。 ########## docs/sql-manual/sql-statements/data-modification/DML/UPDATE.md: ########## @@ -32,6 +34,8 @@ UPDATE target_table [table_alias] + cte: Common Table Expression, eg 'WITH a AS SELECT * FROM tbl' + table_alias: alias of table + FROM additional_tables: Specifies one or more tables to use for selecting rows to update or for setting new values. Note that if you want use target table here, you should give it a alias explicitly. ++ ORDER BY column: Specifies the order in which rows are updated. Typically used together with LIMIT to control which rows are affected. ++ LIMIT [offset,] count: Limits the number of rows to be updated. When used with ORDER BY, updates the first `count` rows after sorting. If `offset` is specified, skips the first `offset` rows before updating. Review Comment: **Suggestion: Document whether LIMIT is usable without ORDER BY** The description says ORDER BY is "typically used together with LIMIT", implying LIMIT may be used alone. If LIMIT without ORDER BY is supported, please document whether the selection of rows is deterministic (e.g., implementation-defined order). If LIMIT requires ORDER BY, say so explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
