HappenLee commented on code in PR #61729: URL: https://github.com/apache/doris/pull/61729#discussion_r2993086973
########## be/src/format/arrow/arrow_row_batch.cpp: ########## @@ -172,7 +172,7 @@ Status convert_to_arrow_type(const DataTypePtr& origin_type, } // Helper function to create an Arrow Field with type metadata if applicable, such as IP types -static std::shared_ptr<arrow::Field> create_arrow_field_with_metadata( +std::shared_ptr<arrow::Field> create_arrow_field_with_metadata( Review Comment: why not keep the func to static -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
