morrySnow commented on PR #61786: URL: https://github.com/apache/doris/pull/61786#issuecomment-4139475411
Re: review comment about `fromThriftBinaryType()` being dead code — `fromThriftBinaryType()` is intentionally included as the symmetric counterpart to `toThriftBinaryType()` to complete the bidirectional conversion API at the Thrift boundary. While there are currently no callers, this method is anticipated for future use cases such as deserializing `TFunction` from BE responses or Thrift RPC results back into `Function.BinaryType`. Keeping it avoids having to add it later when such a need arises, and the cost of the unused method is negligible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
