github-actions[bot] commented on code in PR #14756:
URL: https://github.com/apache/doris/pull/14756#discussion_r1038711803
##########
be/src/vec/exec/vjson_scanner.h:
##########
@@ -52,7 +52,7 @@ class VJsonScanner : public JsonScanner {
const std::vector<TNetworkAddress>& broker_addresses,
const std::vector<TExpr>& pre_filter_texprs, ScannerCounter*
counter);
- Status get_next(doris::Tuple* tuple, MemPool* tuple_pool, bool* eof,
+ Status get_next(doris::Tuple* /*tuple*/, MemPool* tuple_pool, bool* eof,
Review Comment:
warning: parameter 'tuple_pool' is unused [misc-unused-parameters]
```suggestion
Status get_next(doris::Tuple* /*tuple*/, MemPool* /*tuple_pool*/, bool*
eof,
```
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -234,9 +234,7 @@ struct DecimalBinaryOperation {
IsDecimalV2<ResultType>) {
Op::vector_vector(a, b, c);
} else {
- for (size_t i = 0; i < size; i++) {
- c[i] = apply(a[i], b[i]);
- }
+ for (size_t i = 0; i < size; i++) c[i] = apply(a[i], b[i]);
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
for (size_t i = 0; i < size; i++) { c[i] = apply(a[i], b[i]);
}
```
##########
be/src/vec/exec/vjson_scanner.h:
##########
@@ -52,7 +52,7 @@
const std::vector<TNetworkAddress>& broker_addresses,
const std::vector<TExpr>& pre_filter_texprs, ScannerCounter*
counter);
- Status get_next(doris::Tuple* tuple, MemPool* tuple_pool, bool* eof,
+ Status get_next(doris::Tuple* /*tuple*/, MemPool* tuple_pool, bool* eof,
Review Comment:
warning: parameter 'eof' is unused [misc-unused-parameters]
```suggestion
Status get_next(doris::Tuple* /*tuple*/, MemPool* tuple_pool, bool*
/*eof*/,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
