This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-fs-spi
in repository https://gitbox.apache.org/repos/asf/doris.git

commit a7e3a1b1cc66a13ca3914e88aaeb999de3e84a7b
Author: morningman <[email protected]>
AuthorDate: Mon Mar 30 12:23:37 2026 +0800

    [build](fe) Fix Maven build cache incorrectly skipping checkstyle
    
    Maven build cache was caching checkstyle:check results and emitting
    'Skipping plugin execution (cached)' even when sources had changed.
    Two fixes:
    
    1. Add check/checkstyle/ to global cache input so that changes to
       checkstyle rules (checkstyle.xml, suppressions.xml, etc.) correctly
       invalidate all module caches.
    
    2. Mark the checkstyle:check execution (id: validate) as runAlways in
       executionControl so it is never skipped regardless of cache state.
       Checkstyle is a quality gate and must always execute.
    
    Co-authored-by: Copilot <[email protected]>
---
 fe/.mvn/maven-build-cache-config.xml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/fe/.mvn/maven-build-cache-config.xml 
b/fe/.mvn/maven-build-cache-config.xml
index a8a7e18cb0c..38eb08049d1 100644
--- a/fe/.mvn/maven-build-cache-config.xml
+++ b/fe/.mvn/maven-build-cache-config.xml
@@ -30,6 +30,10 @@ under the License.
             <glob>{*.java,*.g4,*.xml,*.properties}</glob>
             <includes>
                 <include>src/</include>
+                <!-- Checkstyle configuration files affect all modules' style 
checks.
+                     Include them globally so any change to checkstyle rules 
invalidates
+                     all cached checkstyle results. -->
+                <include glob="{*.xml,*.txt}" 
recursive="true">check/checkstyle</include>
                 <!-- External source directories under gensrc/ are referenced 
by plugins via
                      Maven properties (e.g. 
${project.parent.basedir}/../gensrc/thrift).
                      The cache extension's tagScanConfig cannot resolve these 
Maven properties,
@@ -44,4 +48,16 @@ under the License.
             </includes>
         </global>
     </input>
+    <executionControl>
+        <runAlways>
+            <!-- Checkstyle is a quality gate that must always execute; never 
use a cached result. -->
+            <executions>
+                <execution artifactId="maven-checkstyle-plugin">
+                    <execIds>
+                        <execId>validate</execId>
+                    </execIds>
+                </execution>
+            </executions>
+        </runAlways>
+    </executionControl>
 </cache>


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to