Mryange opened a new pull request, #61912:
URL: https://github.com/apache/doris/pull/61912
### What problem does this PR solve?
Problem Summary:
### Changes
| File | Description |
|------|-------------|
| `exec/operator/hashjoin_build_sink.cpp` | ASOF join build-side expr: use
`ColumnPtr` directly, remove `result_col_idx` and the subsequent
`block->get_by_position` indirection |
| `exec/operator/join/process_hash_table_probe_impl.h` | ASOF join
probe-side expr: same pattern as above |
| `exec/sink/vrow_distribution.cpp` | Where-clause filter: remove
`result_index` tracking and the `block->erase` cleanup loop (no longer needed
with new interface) |
| `storage/segment/segment_iterator.cpp` | Virtual column materialization:
remove `prev_block_columns` tracking and `erase_tail` call; fix stale
`result_cid` reference in log message |
| `format/transformer/iceberg_partition_function.cpp` | Iceberg
insert/delete partition hash: change `vector<int> results` to
`vector<ColumnWithTypeAndName> results`, use `ColumnWithTypeAndName` overload |
| `exprs/table_function/vjson_each.cpp` | `VExpr::execute` (3-arg) →
`execute_column` |
| `exprs/table_function/vexplode_numbers.cpp` | Same as above |
| `exprs/table_function/vexplode_map.cpp` | Same as above; also fix error
message to use `_collection_column->get_name()` instead of stale block position
lookup |
| `exec/operator/operator.cpp` | **Bug fix**: Remove dead `result_column_id
= -1` that was never updated after migration to new interface; `bytes_usage`
was never accumulated due to `if (result_column_id >= origin_columns_count)`
always being false |
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
