github-actions[bot] commented on PR #61842: URL: https://github.com/apache/doris/pull/61842#issuecomment-4159647538
## Code Review Summary **PR**: [chore](regression) Merge nereids_p0 test cases into query_p0 ### Overview This PR consolidates regression test content from `nereids_p0` into `query_p0`, eliminating 407 duplicate test files. The changes are well-structured: 42 groovy files gain unique test cases from nereids_p0, 24 .out files are updated, 1 new .out file is created, and pipeline configs are adjusted. ### Critical Checkpoint Conclusions 1. **Goal Achievement**: The PR accomplishes its stated goal. All unique test content from `nereids_p0` is merged into `query_p0`, and the duplicate directory is fully deleted. No issues found. 2. **Modification Scope**: Changes are focused entirely on regression test files and pipeline configs. No production code changes. Appropriate for a `[chore]` type PR. 3. **Concurrency**: N/A (test-only changes). 4. **Lifecycle Management**: N/A. 5. **Configuration Items**: Pipeline configs (`cloud_p0/conf/regression-conf-custom.groovy`, `nonConcurrent/conf/regression-conf.groovy`) correctly update exclusion paths from `nereids_p0/` to `query_p0/` to match the new directory structure. No issues. 6. **Incompatible Changes**: N/A for test files. 7. **Parallel Code Paths**: Verified. The PR correctly identifies 42 files needing content merge and leaves unchanged the 77 files where `query_p0` already contained all content. 8. **Test Coverage**: Existing tests are being consolidated, maintaining equivalent coverage. All qt_ tag counts in modified groovy files match their corresponding .out section counts. Verified for 12 key files. 9. **Nereids Cleanup**: Verified clean. Zero leftover references to `nereids_test_query_db` or `nereids_p0` in any modified `query_p0` files. All `enable_nereids_planner` settings properly removed from merged content. 10. **Structural Integrity**: Brace balance verified across all modified groovy files. One pre-existing brace mismatch found in `test_complextype_to_json.groovy` (not introduced by this PR). 11. **Golden Output Files**: All .out files properly match their groovy counterparts. The new `test_show_create_view.out` correctly uses `regression_test_query_p0_show` database name. ### Minor Note (Non-blocking) `AGENTS.md` (not part of this PR) still references `nereids_p0` as an example directory for running regression tests. Consider updating it in a follow-up. ### Verdict **No issues found.** The PR is a clean, mechanical migration of test content with proper cleanup of nereids-specific settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
