github-actions[bot] commented on code in PR #14744:
URL: https://github.com/apache/doris/pull/14744#discussion_r1039351687
##########
be/test/runtime/disk_io_mgr_test.cpp:
##########
@@ -52,8 +52,8 @@ class DiskIoMgrTest : public testing::Test {
void write_validate_callback(int num_writes, DiskIoMgr::WriteRange**
written_range,
DiskIoMgr* io_mgr, DiskIoMgr::RequestContext*
reader,
int32_t* data, Status expected_status, const
Status& status) {
- if (expected_status.code() == TStatusCode::CANCELLED) {
- EXPECT_TRUE(status.ok() || status.is_cancelled());
+ if (expected_status.code() == E_CANCELLED) {
Review Comment:
warning: use of undeclared identifier 'E_CANCELLED' [clang-diagnostic-error]
```cpp
if (expected_status.code() == E_CANCELLED) {
^
```
##########
be/test/olap/tablet_meta_manager_test.cpp:
##########
@@ -92,7 +93,7 @@ TEST_F(TabletMetaManagerTest, TestSaveAndGetAndRemove) {
EXPECT_EQ(Status::OK(), s);
TabletMetaSharedPtr meta_read(new TabletMeta());
s = TabletMetaManager::get_meta(_data_dir, tablet_id, schema_hash,
meta_read);
Review Comment:
warning: '_data_dir' is a private member of 'doris::TabletMetaManagerTest'
[clang-diagnostic-error]
```cpp
s = TabletMetaManager::get_meta(_data_dir, tablet_id, schema_hash,
meta_read);
^
```
**be/test/olap/tablet_meta_manager_test.cpp:68:** declared private here
```cpp
DataDir* _data_dir;
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -421,7 +421,7 @@
}
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
// DeltaWriter's write will return -215
- add_status = Status::OLAPInternalError(OLAP_ERR_TABLE_NOT_FOUND);
+ add_status = Status::Error<TABLE_NOT_FOUND>();
Review Comment:
warning: use of undeclared identifier 'TABLE_NOT_FOUND'; did you mean
'ErrorCode::TABLE_NOT_FOUND'? [clang-diagnostic-error]
```suggestion
add_status = Status::Error<ErrorCode::TABLE_NOT_FOUND>();
```
**be/src/common/status.h:85:** 'ErrorCode::TABLE_NOT_FOUND' declared here
```cpp
E(TABLE_NOT_FOUND, -215);
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -512,7 +512,7 @@
row_batch.commit_last_row();
}
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
- close_status = Status::OLAPInternalError(OLAP_ERR_TABLE_NOT_FOUND);
+ close_status = Status::Error<TABLE_NOT_FOUND>();
Review Comment:
warning: use of undeclared identifier 'TABLE_NOT_FOUND'; did you mean
'ErrorCode::TABLE_NOT_FOUND'? [clang-diagnostic-error]
```suggestion
close_status = Status::Error<ErrorCode::TABLE_NOT_FOUND>();
```
**be/src/common/status.h:85:** 'ErrorCode::TABLE_NOT_FOUND' declared here
```cpp
E(TABLE_NOT_FOUND, -215);
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -512,7 +512,7 @@
row_batch.commit_last_row();
}
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
Review Comment:
warning: 'compressed_size' is a private member of
'doris::LoadChannelMgrTest' [clang-diagnostic-error]
```cpp
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
^
```
**be/test/runtime/load_channel_mgr_test.cpp:121:** declared private here
```cpp
size_t compressed_size = 0;
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -335,7 +335,7 @@ TEST_F(LoadChannelMgrTest, open_failed) {
}
request.set_num_senders(1);
request.set_need_gen_rollup(false);
- open_status = Status::OLAPInternalError(OLAP_ERR_TABLE_NOT_FOUND);
+ open_status = Status::Error<TABLE_NOT_FOUND>();
Review Comment:
warning: use of undeclared identifier 'TABLE_NOT_FOUND'; did you mean
'ErrorCode::TABLE_NOT_FOUND'? [clang-diagnostic-error]
```suggestion
open_status = Status::Error<ErrorCode::TABLE_NOT_FOUND>();
```
**be/src/common/status.h:85:** 'ErrorCode::TABLE_NOT_FOUND' declared here
```cpp
E(TABLE_NOT_FOUND, -215);
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -421,7 +421,7 @@
}
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
Review Comment:
warning: 'uncompressed_size' is a private member of
'doris::LoadChannelMgrTest' [clang-diagnostic-error]
```cpp
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
^
```
**be/test/runtime/load_channel_mgr_test.cpp:120:** declared private here
```cpp
size_t uncompressed_size = 0;
^
```
##########
be/test/runtime/disk_io_mgr_test.cpp:
##########
@@ -52,8 +52,8 @@
void write_validate_callback(int num_writes, DiskIoMgr::WriteRange**
written_range,
DiskIoMgr* io_mgr, DiskIoMgr::RequestContext*
reader,
int32_t* data, Status expected_status, const
Status& status) {
- if (expected_status.code() == TStatusCode::CANCELLED) {
- EXPECT_TRUE(status.ok() || status.is_cancelled());
+ if (expected_status.code() == E_CANCELLED) {
+ EXPECT_TRUE(status.ok() || status.is<E_CANCELLED>());
Review Comment:
warning: use of undeclared identifier 'E_CANCELLED' [clang-diagnostic-error]
```cpp
EXPECT_TRUE(status.ok() || status.is<E_CANCELLED>());
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -512,7 +512,7 @@
row_batch.commit_last_row();
}
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
Review Comment:
warning: 'uncompressed_size' is a private member of
'doris::LoadChannelMgrTest' [clang-diagnostic-error]
```cpp
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
^
```
**be/test/runtime/load_channel_mgr_test.cpp:120:** declared private here
```cpp
size_t uncompressed_size = 0;
^
```
##########
be/test/runtime/load_channel_mgr_test.cpp:
##########
@@ -421,7 +421,7 @@
}
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
Review Comment:
warning: 'compressed_size' is a private member of
'doris::LoadChannelMgrTest' [clang-diagnostic-error]
```cpp
row_batch.serialize(request.mutable_row_batch(), &uncompressed_size,
&compressed_size);
^
```
**be/test/runtime/load_channel_mgr_test.cpp:121:** declared private here
```cpp
size_t compressed_size = 0;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
