iaorekhov-1980 commented on PR #61440: URL: https://github.com/apache/doris/pull/61440#issuecomment-4163068300
Hello, @morningman Could you please proceed with my PR as I've addressed all comments from copilot review and improved test coverage. I've added test coverage for `Auth.checkPlainPassword` and also refreshed PR with actual code base. Regarding check for null passwords, mentioned by copilot, - it is actually out of scope for my feature, because null password is obviously prohibited by existing code in `LDAPManager` line 106 -https://github.com/apache/doris/blob/09eb587703309f2c7044a19cd2895adbdc86b044/fe/fe-core/src/main/java/org/apache/doris/mysql/authenticate/ldap/LdapManager.java#L106 Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
