morrySnow commented on PR #61918: URL: https://github.com/apache/doris/pull/61918#issuecomment-4166979903
Addressed round-2 review comments: 1. **Alter.java NPE risk**: Use `db` parameter instead of `origTable.getDatabase()` + fallback to `INTERNAL_CATALOG_NAME` 2. **MTMVPartitionUtil NPE risk** (x2): Removed redundant lowercasing (constructor handles it) 3. **ShowConstraintsCommand NPE risk**: Removed redundant lowercasing 4. **GlobalVariable CST timezone**: Added `resolveSystemTimeZone()` to remap CST→Asia/Shanghai 5. **ColumnToProtobuf PatternType**: Already fixed to switch with fail-fast default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
