github-actions[bot] commented on code in PR #61922:
URL: https://github.com/apache/doris/pull/61922#discussion_r3019908132
##########
fe/fe-core/src/main/java/org/apache/doris/persist/gson/GsonUtils.java:
##########
@@ -932,6 +932,9 @@ public void write(JsonWriter out, T value) throws
IOException {
((GsonPreProcessable) value).gsonPreProcess();
}
delegate.write(out, value);
+ if (value instanceof GsonPreProcessable) {
+ ((GsonPreProcessable) value).gsonPostSerialize();
Review Comment:
now runs only after returns successfully. That means any object that
materializes transient state in is left dirty if serialization throws midway
through the image write.
now relies on exactly that pattern: fills from the central index before
checkpointing, and is supposed to null it back out. On a failed checkpoint,
this cleanup is skipped, so the checkpoint keeps all of those per-replica s
until teardown. That undermines the memory-saving change on the failure path
where FE is already under pressure.
Please restore a -style cleanup here and preserve the original exception if
both steps fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
