BiteTheDDDDt opened a new pull request, #62056: URL: https://github.com/apache/doris/pull/62056
This pull request improves the safety and clarity of the hash join build sink operator's handling of early termination and hash table signaling. The changes ensure that non-builder tasks do not attempt to access an uninitialized hash table, preventing potential crashes due to type mismatches. Hash join build signaling and termination handling: * In `HashJoinBuildSinkLocalState::close`, the builder task now sets `_signaled = true` only if it was not terminated early, ensuring that non-builder tasks do not attempt to access an uninitialized hash table. Additional comments clarify the logic and the relationship between `_terminated` and `_signaled`. * In `HashJoinBuildSinkOperatorX::sink`, updated the logic and comments to clarify that non-builder tasks will return EOF if the builder has not finished or was terminated early, relying on the improved `_signaled` guard to prevent unsafe access to the hash table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
