dataroaring opened a new pull request, #62122: URL: https://github.com/apache/doris/pull/62122
## Summary - Move `schemaHash` field from base `Replica` class to `LocalReplica`, saving 4 bytes per `CloudReplica` instance - Base `Replica.getSchemaHash()` now returns `-1` (stub), `setSchemaHash()` is a no-op - `LocalReplica` overrides both methods with actual storage - Follows the same pattern as `dbId` removal in #62079 ## Details Cloud storage paths don't use `schema_hash`, and callers like `MetadataViewer` already guard with `getSchemaHash() != -1`, so `CloudReplica` returning `-1` is safe and correct. Changes: - `Replica.java`: Remove `schemaHash` field; `getSchemaHash()` returns `-1`; `setSchemaHash()` is no-op; `toString()` uses `getSchemaHash()` for polymorphism - `LocalReplica.java`: Add `schemaHash` field; override `getSchemaHash()`/`setSchemaHash()`; set in constructor - `CloudReplica.java`: No changes needed (schemaHash param harmlessly ignored by super constructor) ## Test plan - [ ] `CloudReplica.getSchemaHash()` returns -1 - [ ] `LocalReplica.getSchemaHash()` returns actual value - [ ] `MetadataViewer` SCHEMA_ERROR check unaffected (guards with `!= -1`) - [ ] FE unit tests pass (ReplicaTest) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
