github-actions[bot] commented on code in PR #14872:
URL: https://github.com/apache/doris/pull/14872#discussion_r1041738302
##########
be/src/pipeline/exec/operator.h:
##########
@@ -294,38 +294,38 @@
return Status::OK();
}
- virtual Status open(RuntimeState* state) override {
+ Status open(RuntimeState* state) override {
SCOPED_TIMER(_runtime_profile->total_time_counter());
RETURN_IF_ERROR(_node->alloc_resource(state));
return Status::OK();
}
- virtual Status sink(RuntimeState* state, vectorized::Block* in_block,
- SourceState source_state) override {
+ Status sink(RuntimeState* state, vectorized::Block* in_block,
+ SourceState source_state) override {
SCOPED_TIMER(_runtime_profile->total_time_counter());
return _node->sink(state, in_block, source_state ==
SourceState::FINISHED);
}
- virtual Status close(RuntimeState* state) override {
+ Status close(RuntimeState* state) override {
_fresh_exec_timer(_node);
if (!_node->decrease_ref()) {
_node->release_resource(state);
}
return Status::OK();
}
- virtual Status get_block(RuntimeState* state, vectorized::Block* block,
- SourceState& source_state) override {
+ Status get_block(RuntimeState* state, vectorized::Block* block,
+ SourceState& source_state) override {
SCOPED_TIMER(_runtime_profile->total_time_counter());
bool eos = false;
RETURN_IF_ERROR(_node->pull(state, block, &eos));
source_state = eos ? SourceState::FINISHED :
SourceState::DEPEND_ON_SOURCE;
return Status::OK();
}
- virtual Status finalize(RuntimeState* state) override { return
Status::OK(); }
+ Status finalize(RuntimeState* state) override { return Status::OK(); }
Review Comment:
warning: parameter 'state' is unused [misc-unused-parameters]
```suggestion
/*state*/
```
##########
be/src/pipeline/exec/operator.h:
##########
@@ -258,12 +258,12 @@ class DataSinkOperator : public OperatorBase {
return _sink->send(state, in_block, source_state ==
SourceState::FINISHED);
}
- virtual Status close(RuntimeState* state) override {
+ Status close(RuntimeState* state) override {
_fresh_exec_timer(_sink);
return _sink->close(state, Status::OK());
}
- virtual Status finalize(RuntimeState* state) override { return
Status::OK(); }
+ Status finalize(RuntimeState* state) override { return Status::OK(); }
Review Comment:
warning: parameter 'state' is unused [misc-unused-parameters]
```suggestion
/*state*/
```
##########
be/src/pipeline/exec/operator.h:
##########
@@ -283,9 +283,9 @@
Operator(OperatorBuilderBase* builder, ExecNode* node)
: OperatorBase(builder), _node(reinterpret_cast<NodeType*>(node))
{};
- virtual ~Operator() = default;
+ ~Operator() override = default;
- virtual Status prepare(RuntimeState* state) override {
+ Status prepare(RuntimeState* state) override {
Review Comment:
warning: parameter 'state' is unused [misc-unused-parameters]
```suggestion
fault; /*state*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
