github-actions[bot] commented on code in PR #62190:
URL: https://github.com/apache/doris/pull/62190#discussion_r3048819492
##########
be/src/exec/pipeline/dependency.cpp:
##########
@@ -77,9 +77,39 @@ void Dependency::set_ready() {
local_block_task.swap(_blocked_task);
}
for (auto task : local_block_task) {
- if (auto t = task.lock()) {
Review Comment:
`t->is_finalized()` is too narrow for the new "benign late wake-up" check.
`PipelineTask::close()` sets the state to `FINISHED` before `finalize()` flips
it to `FINALIZED` (`pipeline_task.cpp`), so a delayed dependency notification
can legitimately hit a task that is already completed but not yet finalized. In
that window `wake_up()` returns `Task state transition from FINISHED to
RUNNABLE is not allowed`, and this code now cancels the whole fragment even
though the task has already finished.
Please treat the pre-finalize `FINISHED` state as completed too, or key off
the specific state-transition failure instead of only `is_finalized()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
