Mryange opened a new pull request, #62229:
URL: https://github.com/apache/doris/pull/62229
### What problem does this PR solve?
Remove three redundant `materialize_block_inplace` calls where const column
handling is already covered by downstream logic.
**1. `set_sink_operator.cpp`**
`_extract_build_column` already checks `is_column_const()` and calls
`convert_to_full_column_if_const()` for each expression result column. The
preceding `materialize_block_inplace` on the raw input block is redundant.
**2. `vdata_stream_recvr.cpp`**
In the local exchange path, blocks are enqueued and consumed by downstream
operators that handle const columns themselves.
`ColumnConst::allocated_bytes()` correctly reports actual allocated memory, so
memory tracking remains accurate without materialization.
**3. `multi_cast_data_stream_source.cpp`**
The output block enters the pipeline and is processed by downstream
operators, which handle const columns through their own expression evaluation.
No need to materialize here.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
