github-actions[bot] commented on code in PR #62190:
URL: https://github.com/apache/doris/pull/62190#discussion_r3050749502
##########
be/src/exec/pipeline/pipeline_task.h:
##########
@@ -118,7 +118,7 @@ class PipelineTask : public
std::enable_shared_from_this<PipelineTask> {
return _op_shared_states[id].get();
}
- Status wake_up(Dependency* dep, std::unique_lock<std::mutex>& /* dep_lock
*/);
+ void wake_up(Dependency* dep, std::unique_lock<std::mutex>& /* dep_lock
*/);
Review Comment:
This signature change is not fully propagated yet.
`be/test/exec/pipeline/pipeline_task_test.cpp:557` still does
`EXPECT_TRUE(task->wake_up(dep.get(), lc).ok());`, so the PR no longer compiles
because `wake_up()` now returns `void`. Please update that remaining test call
site together with the two lines already changed above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
