github-actions[bot] commented on PR #62266: URL: https://github.com/apache/doris/pull/62266#issuecomment-4212440246
No issues found in my review. Checkpoint summary: - Goal and test coverage: The PR broadens `coalesce` simplification to remove interleaved and trailing `NULL` literals, and the added FE unit tests cover the new rewrite shapes. - Scope/minimality: The change is focused to one Nereids rewrite rule plus its tests. - Concurrency: Not applicable; this is a pure FE expression rewrite with no shared-state or locking changes. - Lifecycle/static init: No special lifecycle or static-initialization risk introduced. - Config/compatibility/FE-BE protocol/transactions/persistence/data writes: Not applicable. - Parallel code paths: I did not find another equivalent rewrite path that also needed updating. - Conditional logic: The new conditions are consistent with `coalesce` semantics and do not introduce rewrite-loop risk because unchanged rebuilt expressions compare equal and are not re-applied. - Observability: No additional observability needed for this local optimizer rewrite. - Performance: The rewrite removes redundant `NULL` arguments and can shorten later evaluation; no obvious regression found. - Other issues: None found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
