Kikyou1997 commented on code in PR #14862:
URL: https://github.com/apache/doris/pull/14862#discussion_r1042860613
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/EliminateGroupByConstant.java:
##########
@@ -50,6 +51,7 @@ public Rule build() {
List<NamedExpression> outputExprs =
aggregate.getOutputExpressions();
Set<Expression> slotGroupByExprs = Sets.newLinkedHashSet();
for (Expression expression : groupByExprs) {
+ expression = FoldConstantRule.INSTANCE.rewrite(expression);
Review Comment:
We could do this after the process for FoldConstant is complete, for now,
there still might be some expression like `1+1` not get folded here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
