github-actions[bot] commented on code in PR #62282:
URL: https://github.com/apache/doris/pull/62282#discussion_r3063510297
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/OlapInsertExecutor.java:
##########
@@ -87,8 +87,8 @@ public class OlapInsertExecutor extends
AbstractInsertExecutor {
*/
public OlapInsertExecutor(ConnectContext ctx, Table table,
String labelName, NereidsPlanner planner,
Optional<InsertCommandContext> insertCtx, boolean emptyInsert,
- long jobId) {
- super(ctx, table, labelName, planner, insertCtx, emptyInsert, jobId);
+ long jobId, boolean needRegister) {
+ super(ctx, table, labelName, planner, insertCtx, emptyInsert, jobId,
needRegister);
Review Comment:
Changing `OlapInsertExecutor` to an 8-argument constructor breaks the
subclasses that still call the old 7-argument `super(...)`. In this patch,
`OlapTxnInsertExecutor` (line 46), `OlapGroupCommitInsertExecutor` (line 69),
and `RemoteOlapInsertExecutor` (line 81) still invoke the removed signature, so
FE no longer compiles. Please either keep the old overload or update all
subclasses in the same change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
