Kikyou1997 commented on code in PR #14910:
URL: https://github.com/apache/doris/pull/14910#discussion_r1046110707
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -68,6 +69,7 @@ public class ColumnStatistic {
public final double avgSizeByte;
public final double minValue;
public final double maxValue;
+ public final Histogram histogram;
Review Comment:
I think we'd better to place Histogram as a field of ColumnStatistic,
though it looks very natural.
Because the calculation of Histogram is much costful than others. We manage
it in a separate structure would make
the framework more flexible and avoid to low down the calculation of other
statistics as possible as we cam.
Above is just my personal view, I think it needs a further discussion in the
community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
