morningman commented on code in PR #14470:
URL: https://github.com/apache/doris/pull/14470#discussion_r1046770808
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -268,7 +268,10 @@ struct TIcebergFileDesc {
1: optional i32 format_version;
// Iceberg file type, 0: data, 1: position delete, 2: equality delete.
2: optional i32 content;
- 3: optional list<TIcebergDeleteFileDesc> delete_files;
+ // When open a delete file, filter the data file path with the 'file_path'
property
+ 3: optional Exprs.TExpr file_select_conjunct;
Review Comment:
Do not change the origin order
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -308,10 +311,8 @@ struct TFileScanRangeParams {
14: optional list<Types.TNetworkAddress> broker_addresses
15: optional TFileAttributes file_attributes
16: optional Exprs.TExpr pre_filter_exprs
- // For data lake table format
- 17: optional TTableFormatFileDesc table_format_params
// For csv query task, same the column index in file, order by dest_tuple
- 18: optional list<i32> column_idxs
+ 17: optional list<i32> column_idxs
Review Comment:
do not change order.
If you want to delete a optional field, just delete it.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##########
@@ -134,18 +173,27 @@ public List<InputSplit> getSplits(List<Expr> exprs)
throws UserException {
scan = scan.filter(predicate);
}
List<InputSplit> splits = new ArrayList<>();
-
int formatVersion = ((BaseTable)
table).operations().current().formatVersion();
+ if (formatVersion >= MIN_DELETE_FILE_SUPPORT_VERSION) {
+ TableName fullName =
analyzer.getFqTableName(scanDeleteTable.getTableName());
+ fullName.analyze(analyzer);
+ TableRef ref = new TableRef(fullName, fullName.toString(), null);
+ BaseTableRef tableRef = new BaseTableRef(ref, scanDeleteTable,
scanDeleteTable.getTableName());
+ tableRef.analyze(analyzer);
+ scanDeleteTable.setBaseTableRef(tableRef);
Review Comment:
Can not set base table ref to a static member
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
