github-actions[bot] commented on code in PR #62222:
URL: https://github.com/apache/doris/pull/62222#discussion_r3193116542
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -5483,6 +5493,7 @@ public TQueryOptions toThrift() {
Review Comment:
This leaves the advertised compatibility alias non-functional.
`enable_common_expr_pushdown` still has its own FE field and is still sent to
BE as `enable_common_expr_pushdown`, but BE now gates SegmentIterator
filter/LIMIT pushdown only on `enable_segment_filter_and_limit_pushdown`
(`RuntimeState::enable_segment_filter_and_limit_pushdown()`). A user, saved
session setting, or mixed-version FE that sets `enable_common_expr_pushdown =
false` will still leave this new option true/default, so the renamed pushdown
remains enabled despite the alias comment. Please map the old variable into the
new option (for example by sending `enableSegmentFilterAndLimitPushdown &&
enableCommonExprPushdown`, or by keeping BE honoring the old thrift field) and
add a compatibility regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
