github-actions[bot] commented on code in PR #62713:
URL: https://github.com/apache/doris/pull/62713#discussion_r3193490083
##########
regression-test/suites/dictionary_p0/test_ddl.groovy:
##########
@@ -125,7 +125,7 @@ suite("test_ddl") {
)LAYOUT(HASH_MAP)
properties('data_lifetime'='600');
"""
- exception "Key column k1 cannot be complex type"
+ exception "cannot be Map or Struct type"
Review Comment:
This negative case now contradicts the feature.
`CreateDictionaryInfo.validateKeyColumn()` no longer rejects complex HASH_MAP
keys, and the new regression suite creates MAP and STRUCT key dictionaries
successfully, but this test still expects a MAP key to fail with `cannot be Map
or Struct type`. I also do not see that exact error emitted by the updated
implementation, so this looks like a stale assertion that can make `test_ddl`
fail or mask the intended MAP-key support. Please either remove/change this
case to an actually unsupported shape, or add an explicit production-side
rejection if `MAP<STRING, INT>` is still meant to be unsupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
