Ryan19929 opened a new pull request, #63011:
URL: https://github.com/apache/doris/pull/63011
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #58897
Problem Summary:
This is the first PR of a series that enables RESTORE to choose the target
storage medium in a clear and consistent way.
To support that RESTORE feature, Doris first needs a stable table/partition
metadata model for storage medium allocation. This series also makes storage
medium selection consistent between CREATE TABLE and RESTORE.
The complete series will introduce:
- `STRICT` / `ADAPTIVE` medium allocation semantics.
- CREATE TABLE hard binding: specifying `storage_medium` means `STRICT`;
omitting it means `ADAPTIVE`.
- RESTORE medium properties, including `same_with_upstream`, in follow-up
PRs.
- A unified `MediumDecisionMaker` for restore scenarios in follow-up PRs.
- FE-BE per-task fallback control (`allow_medium_fallback`) in follow-up PRs.
This PR only builds the table-level metadata foundation. It does not change
RESTORE behavior yet.
Main changes in this PR:
- Add `MediumAllocationMode` (`STRICT` / `ADAPTIVE`).
- Persist `mediumAllocationMode` in `DataProperty`.
- Keep `TableProperty.mediumAllocationMode` as a rebuilt cache from table
properties.
- Map CREATE TABLE `storage_medium` to `STRICT`; unspecified medium remains
`ADAPTIVE`.
- Change `SystemInfoService.selectBackendIdsForReplicaCreation` and cloud
override to accept `MediumAllocationMode` instead of a boolean.
- Keep old image compatibility by defaulting missing `mediumAllocationMode`
to `ADAPTIVE`.
This also fixes the previous `storageMediumSpecified` problem: the old
boolean was not persisted because it had no `@SerializedName`.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]