Mryange commented on code in PR #62582:
URL: https://github.com/apache/doris/pull/62582#discussion_r3194855838


##########
be/src/storage/partial_update_info.cpp:
##########
@@ -724,7 +724,7 @@ static void fill_non_primary_key_cell_for_row_store(
                 // store the generated auto-increment value in fixed partial 
update
                 new_col->insert_from(cur_col, block_pos);
             } else {
-                new_col->insert(tablet_column.get_vec_type()->get_default());
+                new_col->insert_default();

Review Comment:
   只有当这个列被删除的时候才会插入到默认值,可以看修改的回归,delete 列为1



##########
be/src/storage/tablet/base_tablet.cpp:
##########
@@ -1125,7 +1125,7 @@ static void fill_cell_for_flexible_partial_update(
                 //       keep consistency between replicas
                 new_col->insert_from(cur_col, 
read_index_update[cast_set<uint32_t>(idx)]);
             } else {
-                new_col->insert(tablet_column.get_vec_type()->get_default());
+                new_col->insert_default();

Review Comment:
   只有当这个列被删除的时候才会插入到默认值,可以看修改的回归,delete 列为1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to