BiteTheDDDDt commented on code in PR #15043:
URL: https://github.com/apache/doris/pull/15043#discussion_r1048212388
##########
be/src/vec/functions/function_string.h:
##########
@@ -893,22 +893,21 @@ class FunctionStringConcatWs : public IFunction {
const auto& src_array_offsets = array_column.get_offsets();
size_t current_src_array_offset = 0;
+ auto& sep_offsets = *offsets_list[0];
+ auto& sep_chars = *chars_list[0];
+ auto& sep_nullmap = *null_list[0];
+ int sep_size = sep_offsets[0];
+ const char* sep_data = reinterpret_cast<const char*>(&sep_chars[0]);
+ std::string_view sep(sep_data, sep_size);
+
Review Comment:
Your are right, finally I find the real reason of overflow is version() not
process input_rows_count rightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
